feat: add enable and disable methods to RulesEndpoint#270
Open
pachuho wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: 32aa59f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Adds support for the rule status endpoints (PUT /rules/{id}/status/enable
and PUT /rules/{id}/status/disable). These endpoints are available in the
SmartThings public Postman workspace but were not previously exposed in
this SDK.
Verified against the live API: both calls return 204 and toggle the
rule's status field between Enabled and Disabled.
First step toward SmartThingsCommunity/smartthings-cli#500.
pachuho
force-pushed
the
feat/rules-enable-disable
branch
from
f085891 to
32aa59f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
enable()anddisable()toRulesEndpoint, covering the rule status endpoints:PUT /rules/{ruleId}/status/enable?locationId={locationId}PUT /rules/{ruleId}/status/disable?locationId={locationId}These are in the SmartThings public Postman workspace ("Update Rule status (enable/disable)") but missing from the SDK. SmartThingsCommunity/smartthings-cli#500 asks for enable/disable in the CLI and notes it needs SDK support first — I'd like to follow up with a CLI PR once this lands.
Both methods return
Promise<void>since the API responds with 204 and no body.Tested against the live API with a
w:rules:*scoped token: both calls return 204 and a subsequentGETshowsstatustoggling betweenEnabled/Disabled. Unit tests added, lint and full suite pass, changeset included.